cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH 7/8] tests: use single quotes for some tests

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 10 Nov 2014 09:25:13 +0100 (CET)

On Thu, 6 Nov 2014, Peter Wu wrote:

> This prepares for a future patch where commands are not executed by a shell
> anymore, but by perl. In the future, Text::ParseWords will be used to
> convert a command to an array.

I prefer to bundle this change with this "future patch" you're talking about.
Especially since we don't do anything to prevent new double-quotes to be
introduced with the same use case.

Is Text::ParseWords a module that is installed by default with perl? I'm
hesitant to require any addditional stuff for perl.

Also, what is the benefit of letting perl do this and not the shell? Are you
planning to make the test suite able to run completely without a shell? If so,
what are the benefits and the drawbacks?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-10