cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH 0/2] CMake: Fix order-dependent header and library checks

From: Jakub Zakrzewski <jzakrzewski_at_e2e.ch>
Date: Tue, 11 Nov 2014 21:02:09 +0000

> please provide the necessary +1 when ready.

Sure, from my point of view it's reverting the old, working behaviour. The purpose is clear, so +1 from me.

> IIRC the checks were originally written that way many years
> ago to duplicate what the non-CMake buildsystem was doing
> for its checks at the time.

Exacltly, what I don't like about those systems ;)

> Most of the headers/libs do
> not actually have dependencies on all of the preceding ones.
> Those without dependencies could be split out and made
> independent. Those with dependencies could be spelled out
> explicitly in order. That would take some investigation
> and a lot of testing though.

That's what I was trying to achieve. However I have really poor test environment as it turned up.

> For now though, the old logic needs to be restored to fix
> the build on OS X and a few other platforms.

No argument here.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-11