cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH 2/7] pipelining: Fix connection handling under timeouts.

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 18 Nov 2014 14:50:28 +0100 (CET)

On Mon, 17 Nov 2014, Carlo Wood wrote:

> Attached a new patch. I went ahead and also fixed this test in
> curl_multi_remove_handle and then that whole function by removing the silly
> pipeline test and fixing easy_owns_conn, as mentioned on IRC; that part then
> fixes the correct closing of a connection when the user calls
> curl_multi_remove_handle() before a transaction finished, which is very much
> like the timeout.

Thanks a lot!

Applied and pushed just now. I did two other minor cleanup commits as well,
but they shouldn't be much in your way I hope. Possibly the renaming of
'result' to 'rc' in multisingle is a minor nuisance but it is a step along the
libcurl-wide cleanup move to always use 'result' as the name for the CURLcode
variable.

Another step forward. Let me know how you want to proceed with the pending
patches and changes you have.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-18