cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] smb/cifs

From: Nagel, Bill <wnagel_at_tycoint.com>
Date: Mon, 24 Nov 2014 17:30:07 +0000

> > Do you prefer that I rename the types and avoid stdint? Like "smb_u32".
>
> For the purpose of the project and anyone else maintaining this after your
> initial work I'd rather you use native C89 compatible types rather than either
> your own or C99 types.
>

At the minimum I need to typedef a 64-bit int.

> > I will go with this, and add SSPI support in a later patch:
>
> If you modify curl_ntlm_core.c to not have USE_WINDOWS_SSPI around the
> following functions then I believe it will compile probably under a SSPI based
> build:
>
> Curl_ntlm_core_mk_lm_hash()
> Curl_ntlm_core_lm_resp()
> nt_hash()
>
> If you then place the following around the SMB code then the project should
> build when we don't have a crypto layer, auth support has been disabled or
> NTLM has been disabled:
>
> #if !defined(CURL_DISABLE_SMB) && defined(USE_NTLM)

It might build, but it would not work because those functions need md4 and des. So I will add SSPI support in a later patch.

-Bill

________________________________

This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-24