cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] nss: implement public key pinning for NSS backend

From: moparisthebest <admin_at_moparisthebest.com>
Date: Wed, 01 Apr 2015 12:01:24 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 03/25/2015 09:13 AM, Kamil Dudka wrote:
> As the feature window is already closed, I am sending this just to
> get some feedback on the patch, will merge it after the release
> eventually.

I can't comment on the NSS specific code, but it looks complete
otherwise as to updating all the docs, runtests.pl, and calling the
shared Curl_pin_peer_pubkey() function correctly. If it passes all 4
pinning tests (der pass/fail, pem pass/fail) with NSS it should be
good to go!

Great to see the number of supported backends growing!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQQcBAEBCgAGBQJVHBZUAAoJEOy5uMuqxowDsucgAL3p+jI2pa6iVuZg+zBSJaPj
wsIz3Q0r+ZXXXk9vqISxeyC/g6Fe7OZqDGD8HoWuz8bVqeu+kgMrLPXB/Me94c4e
BQ2skn1fQTgAWjYJxd9T1jChJebMj61cw57FG+gI7aaaY4yVPwt87SYwKyDXvUPP
uquKUaNGFiZcDbgiW0DugYVQixo1u6ODdmZbt77/m51fHFswSVvOkvo78Q/gcMb1
5f77m/70IwKrNnF9PJe2nc3GQpeqNJOLcUExoMyTjK5d2UC4yHNUZfVSGnaPTY/i
Vl+F9/gIIuY8jsyCnAmXgIGRrmkGxtZJvOdyFTkg6gZxSA3F8bw4wfEx255pThCl
ygnoIQyA1GySCYd9E+5Q0H+0bedlPjbuAU5B7wWuDWW5gkQMzRJTdG+SQr35VQrS
mzxzdq65szJOhcglhiXU4m+8XWS2ebRT3p+da+lDD6KkLzHX3rhcyvbL+lyh21fG
VaFSpngyqDcuLxBHXujmDot5CYmx/aGxSf9tZk5Ic59SRqa2w466Q+kCn+UlKjtX
EBEnclJza4ZvyV0E1dMqrbQ04t8y11geOt49uYOxmJnDu+czaOpFomOGAjeGF0NO
maE/Pi6jcoBms9mVNCzWt5XRnRDAoPa9qKmHgA9ex0bbu9aKPN2rB38WR1i+V9B4
e9kwPA2A0W82j2CIhrgRur7HiG3JF1d4oNu/DUPBSKTLjnl4NpAO/vEMxji7D1I1
olr5QS1/RVQcQ+fMBJ/r5BWp/ozEtNgxRAdR25O+/aZ65fBLtzVBaNObi1U9Eysz
oC/0Ch4nr+9wZpChYwPj/OLdp62RX5/hQxc51jrc01oOESu53dhDDqx56KNe/wZi
zg+CpkhEPJM0nnczhyN325VQh9OCjqJneDdlJKlcnNV1Np069SMaEqyrHbcNF/8f
OD3v/ArPxhCyeCWlqY3BlIlCRbDMPoa6rCtFjgcCUPXfo3SvRmtj6SlwKi9Q7bP1
+IxDL87bGjvM0y4FdeFzJaw3SWmHni9O8bLGS1CLGi4c2BbMFcmAwFIBvfcAaVaF
MzLExfE/U5Wi2Xs3OXvcEVBW8mxCCEDJxhuFzG3vyLzEU6HB8v+N0LopKPMtH+ha
zF0cZ7qdF4FWM9zEG/Mu6HQNaC2VlaDu1DKr1mE62dWuM8odnTeAChsfXwZtaPJl
79uKlNl6HypCufBilHTpvpi78f+ULmYzUwPjPebLgEC8/BfuegHvcM1cAHh6SM7W
GJYJlCd9huhlnRMtZ642ONp6LQXMQH8RoMpeWwLf+K56kTb6kUhF90XOn8Vzz7wh
d2dB2aCMwJl4ThpbCGOU4tsPaX9VbB8P1qZJxHj9NdtL/T+vMUhb/AotdnFDH1Y=
=JJ86
-----END PGP SIGNATURE-----
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-04-01