cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: http2: basic multiplexing seems to work now

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 7 May 2015 17:36:07 +0200 (CEST)

On Thu, 7 May 2015, Tatsuhiro Tsujikawa wrote:

> ​I tried to make uploading work in multiplexed manner.

Cool, I haven't gotten around to that yet. I've tried going over the
MAX_CONCURRENCY limit and I'm thinking of ways to handle that nicely...

> Well it partially worked actually. The thing is 2 uploads did not happen
> simultaneously, instead it happened sequentially. I guess that pipelining
> code may serialize uploading as a part of request, but I have not checked it
> yet.

I'm pretty sure that's a correct suspicion. I just pushed one change that may
affect it in a positive direction but I'm sure there are some more details
like that left to fix.

> Another issue is upload speed is very slow. It seems like it uploads one
> DATA frame per second. Probably, current code does not check that socket is
> writable?

Yeah, I think it may suffer from a similar issue that I ran into for download:
when many streams share the same socket we need to go through several handles
to send data for which the current code really never have done.

> I'll share my code later.

Excellent!

> PS: I submitted PR on github to fix several issues I encountered while
> playing around multiplex branch.
> https://github.com/bagder/curl/pull/260

I noticed. Thanks a bunch, I'll merge those as soon as possible!

-- 
  / daniel.haxx.se

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-05-07