cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: better handling of websocket protocol upgrades

From: Frank Meier <frank.meier_at_ergon.ch>
Date: Wed, 29 Jul 2015 18:07:38 +0200

On 25/07/15 01:03, Daniel Stenberg wrote:
>> If Curl_getconnectinfo() would not not just care about "lastconnect"
>> socket, but also would retrieve the connection that is actually being
>> used, my approach would work. This was suggested in
>> https://github.com/bagder/curl/pull/86, but was never merged.
>
> That change alone would not make this a reliable method. You need to
> write documentation and test cases too. And I think I would be fine
> with it, it seems like an easy change that shouldn't break anything
> existing.
I take you up on this. I wrote a slightly different patch, that does
primary retrieve the active connection socket if the session handle is
still used, otherwise it retrieves the last used connection. I also
updated the documentation and added a testcase (1532).

cheers, Frank

Received on 2015-07-29