cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: CURLINFO_TLS_SESSION with OPENSSL returns SSL_CTX instead of SSL

From: Michael König <plasm_at_plasm.de>
Date: Mon, 5 Oct 2015 12:37:38 +0200 (CEST)

> Ray Satiro via curl-library <curl-library_at_cool.haxx.se> hat am 2. Oktober 2015
> um 20:34 geschrieben:
>
>
> On 10/2/2015 3:39 AM, Michael König wrote:
> >> Ray Satiro via curl-library <curl-library_at_cool.haxx.se> hat am 1. Oktober
> >> 2015
> >> um 21:03 geschrieben:
> >>
> >> Here is another idea, piggyback on CURLINFO_TLS_SESSION instead.
> >> CURLINFO_TLS_SESSION_V2 returns OpenSSL SSL * but is otherwise the same
> >> as CURLINFO_TLS_SESSION:
> >>
> >> https://github.com/jay/curl/compare/master...jay:curlinfo_tls_session_v2?expand=1
> >>
> > If it was intended to eventually deprecate the current CURLINFO_TLS_SESSION
> > and replace it with the V2 version this would make sense. If that will not
> > be the case i think going with the maximum distance to CURLINFO_TLS_SESSION,
> > regarding the returned values, while doing what we want is the way to go. To
> > justify the existance of the new enum.
>
> I'm not sure what you mean by "going the maximum distance". If you mean
> change the structure to be more "full" so that V2 returns both the
> SSL_CTX and SSL I think that's unnecessary because you can get the
> SSL_CTX from the SSL. It appears this was just an oversight that SSL_CTX
> instead of SSL is returned for OpenSSL in V1.
Maximum distance as in: Put in as much new value for users as possible, while
staying
in scope of the topic.
I was not too fond of CURLINFO_TLS_SESSION_V2 just fixing this one thing, maybe
more
could be done with it and in that case it would warrant a different name.

Since then i revised my opinion. CURLINFO_TLS_SESSION_V2 makes it pretty clear
it is
a bugfix. It was said before it is pretty much the only way to go to maintain
backward
compatibility.

The most important thing is that something is done about the SSL object really.

Sorry for the longish delay. Was ill part of last week and through the weekend.

Greetings,
  Michael

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-10-05