cURL / Mailing Lists / curl-library / Single Mail

curl-library

LIBCURL_TIMESTAMP is in wrong format

From: Tetetest <tetetest_at_rambler.ru>
Date: Sun, 24 Jan 2016 13:25:13 +0300

Hello libcurl,

In 7.46.0 tarballs' include/curl/curlver.h, LIBCURL_TIMESTAMP is
defined to a string in non-English locale (I guess it is Swedish).
This contradicts the comment above it:

/*
 * This is the date and time when the full source package was created. The
 * timestamp is not stored in git, as the timestamp is properly set in the
 * tarballs by the maketgz script.
 *
 * The format of the date should follow this template:
 *
 * "Mon Feb 12 11:35:33 UTC 2007"
 */
#define LIBCURL_TIMESTAMP "ons 2 dec 2015 07:02:16 UTC"

I guess the problem is in maketgz script which calls `date -u' on a
box with Swedish locale:

maketgz:
# requires a date command that knows -u for UTC time zone
datestamp=`date -u`

I think we should set the locale to "C" somewhere at the beginning o\f
the script, like it is done in 'configure':

#
# Set internationalization behavior variables.
#

LANG='C'
LC_ALL='C'
LANGUAGE='C'
export LANG
export LC_ALL
export LANGUAGE

PS:

7.45.0 tarballs also have the "bug":
#define LIBCURL_TIMESTAMP "ons 7 okt 2015 08:14:10 UTC"

7.44.0 and before are okay:
#define LIBCURL_TIMESTAMP "Wed Aug 12 06:10:30 UTC 2015"
#define LIBCURL_TIMESTAMP "Wed Jun 17 05:56:00 UTC 2015", etc.

-- 
Best regards,
 Tetetest                          mailto:tetetest_at_rambler.ru
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2016-01-24