cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [Patch] accept any RTSP session id

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 11 Aug 2016 08:55:48 +0200 (CEST)

On Tue, 9 Aug 2016, Erik Janssen wrote:

> I propose the following small change to make libcurl work in communication
> with gstreamer-based RTSP servers. See attached patch against 7.50.1. The
> original code validates the session id to be in accordance with the RFC. I
> think it is better not to do that:

Ok, I was sloppy and didn't run the tests before I merged this. It turns out
we have test 569 that verifies that we don't accept spaces as part of the RTSP
session id. Like this:

   Session: \$extraspaces ignore-this-part-------;foo=bar

So, do you think we should fix the test and allow the entire string to be the
session (including spaces) or should we fix the code and also stop the parsing
at the first space?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html
Received on 2016-08-11