On Mon, Mar 13, 2017 at 12:04:58AM +0100, Daniel Stenberg wrote:
> On Sun, 12 Mar 2017, Dan Fandrich wrote:
>
> >The docs/curl.1 file in the daily snapshot tarballs is not being regenerated
> >for each release.
>
> There's a flaw in the makefiles that makes the curl.1 not get rebuilt as it
> should. It can be seen with this experiment:
>
> $ touch docs/cmdline-opts/max-time.d
> $ make
>
> ... and docs/curl.1 is not rebuilt! Turns out this is because we don't build
> in docs/.

I looked within docs and docs/cmdline-opts but never bothered to check the
higher-level directory!

> index eee44d875..98ea29310 100644
> --- a/docs/Makefile.am
> +++ b/docs/Makefile.am
> @@ -28,11 +28,12 @@ GENHTMLPAGES = curl.html curl-config.html
> mk-ca-bundle.html
> PDFPAGES = curl.pdf curl-config.pdf mk-ca-bundle.pdf
> MANDISTPAGES = curl.1.dist curl-config.1.dist
>
> HTMLPAGES = $(GENHTMLPAGES) index.html
>
> -SUBDIRS = examples libcurl cmdline-opts
> +SUBDIRS = libcurl cmdline-opts
> +DIST_SUBDIRS = $(SUBDIRS) examples

This part of the patch has the effect of never actually building the examples.
They're only built on "make check" so they don't interfere with normal builds,
but it's a useful sanity check that they're still compilable.

>>> Dan
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2017-03-13