curl / Mailing Lists / curl-library / Single Mail

curl-library

Proxy CONNECT aborted after 7.55.0

From: Yasushi Oshima via curl-library <curl-library_at_cool.haxx.se>
Date: Sun, 3 Sep 2017 14:31:37 +0900

Hello,

I'm using Git with libcurl.

After updating libcurl from 7.54.1 to 7.55.0 or 7.55.1, git command
cannot
connect to https repository through http-proxy with basic-auth.

$ git fetch
fatal: unable to access 'https://github.com/curl/curl': Proxy CONNECT
aborted

When downgrade to 7.54.1, it works fine.

I saw some changes in libcurl 7.55.0, then, I found followings:

- https://github.com/curl/curl/blob/curl-7_55_0/lib/http_proxy.c#L343

Just return with CURLE_OK when Curl_read() is CURLE_AGAIN.
However, Iit seems that 'continue' in the same case till 7.54.1,

- https://github.com/curl/curl/blob/curl-7_54_1/lib/http_proxy.c#L323

I changed to 'continue' in 7.55.1 as for trial and rebuild libcurl,
then it is able to connect normally, becomes to work well again.

Is this a bug? or another causes?

My environment:
 1: Git for windows 2.14.1, it has curl 7.55.0.
     https://github.com/git-for-windows/git/releases/tag/v2.14.1.windows.1
 2: NetBSD/amd64 7.1. 7.55.1 self build binary with pkgsrc
      http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/www/curl/
 Same problem occurs on both environment.

Thanks,

-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2017-09-03