curl / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] curl: Fix compile warning on Fedora-14.

From: Kamil Dudka via curl-library <curl-library_at_cool.haxx.se>
Date: Mon, 11 Sep 2017 12:40:08 +0200

On Saturday, September 9, 2017 12:37:00 AM CEST Ben Greear wrote:
> I like to build with -Werror, and so this warning 'breaks' my build.

Why? There are more sophisticated ways to capture compile-time warnings
and to process them automatically (instead of manually checking the build
log after a failure caused by -Werror).

> That really is the sole reason I'd even post this patch, as the original
> code is correct as far as I can tell.
>
> That said, the ? operator always makes me think a bit harder, so I rarely
> use them anyway when I can easily not use them.

While I respect your opinion, I disagree on this. Not using ternary operator
leads to code duplication, which some programmers, including me, try to avoid.

Kamil

> So, either way is fine with me.
>
> Thanks,
> Ben
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2017-09-11