curl / Mailing Lists / curl-library / Single Mail

curl-library

Re: Uncompress HTTP responses if no Accept-Encoding was sent?

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 25 Apr 2018 14:56:13 +0200 (CEST)

On Wed, 25 Apr 2018, Rainer Canavan wrote:

> I would conclude that libcurl should still try to decompress a
> response with a supported Content-Encoding, however
> Curl_http_readwrite_headers() explicitly checks if
> data->set.str[STRING_ENCODING] was set (i.e. an Accept-Encoding header
> was sent), and therefore disables compression.
>
> I would simply remove that check for STRING_ENCODING. Opinions?

I'm only worried for the users out there who have the decompression ability
built-in, but are using libcurl to download the compressed data for storage or
something. Changing this to unconditionally decompressing would make it
impossible for such a built library to get the compressed version.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html
Received on 2018-04-25