curl / Mailing Lists / curl-library / Single Mail

curl-library

Fixes/patch for curl-7.60.0 (fwd)

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 18 May 2018 08:55:43 +0200 (CEST)

Hey all,

Here's Stefan's suggested patch for a few windows build issues.

At least the "add the manifest" part has already been discussed and left
without action [1].

I personally am not a windows developer; I need guidance and feedback from
those of you who are and have opinions on this patch. Either for or against.

[1] = https://github.com/curl/curl/issues/2326

(Stefan is not subscribed, keep him CC'ed when replying)

-- 
  / daniel.haxx.se
---------- Forwarded message ----------
From: Stefan Kanthak
Hi all,
the attached patch adds an icon (copy <https://curl.haxx.se/favicon.ico>
as curl.ico into the top level directory of the source tree) to the
Windows executables, plus an application manifest to prevent DLL
hijacking, and fixes some minor bugs in winbuild\MakefileBuild.vc:
some time ago Steve (?) added the macro RC = rc.exe, but replaced
only the first occurence of rc[.exe], not the second at the end of
Makefile.vc
Also builds with the compilers distributed with the Platform SDK
for Windows Server 2003 (which is named in winbuild\BUILD.WINDOWS.txt)
work now.
regards
Stefan Kanthak


-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html

Received on 2018-05-18