curl / Mailing Lists / curl-library / Single Mail
Buy commercial curl support from WolfSSL. We help you work out your issues, debug your libcurl applications, use the API, port to new platforms, add new features and more. With a team lead by the curl founder himself.

Re: curl --data slow with big file

From: Daniel Stenberg via curl-library <curl-library_at_cool.haxx.se>
Date: Thu, 12 Sep 2019 09:28:51 +0200 (CEST)

On Thu, 12 Sep 2019, Gilles Vollant via curl-library wrote:

> And in src/tool_paramhlp.c, the function file2string does very often realloc

Oh right. Once *per line* of the file. For a 100MB json file, I bet that can
end up in quite a lot of reallocs!

> So I suggest modifying file2string to call realloc less often, like
> file2memory.

That's a very good idea. Are you willing to work on it?

-- 
  / daniel.haxx.se | Get the best commercial curl support there is - from me
                   | Private help, bug fixes, support, ports, new features
                   | https://www.wolfssl.com/contact/
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html
Received on 2019-09-12