Re: Two curl pull request for Windows

On Sun, 15 Sep 2019, Gilles Vollant wrote:

> https://github.com/curl/curl/pull/4346/commits
> I see a green mark "pass" only on the 5d01a00 commit
> But not at the latest commit c6af726
> c6af726 only change calling a Windows api Unicode to call ansi api to do the
> same thing
> both 5d01a00 and c6af726 work as fine.

Thanks a lot for your work!

I've commented on the PR about that red. It is the boringssl build that no
longer works on travis. Unrelated to your changes.

I've also mentioned some other minor detail with your code there.

Alessandro Ghedini has some work ongoing in
https://github.com/curl/curl/pull/4355 that might fix those particular
problems soon.

> The second: https://github.com/curl/curl/pull/4356 add support of client
> certificate in .P12 or .PFX file with compiling whith schannel

I've commented in the PR. There's a compiler error found on appveyor to fix!

-- 
  / daniel.haxx.se | Get the best commercial curl support there is - from me
                   | Private help, bug fixes, support, ports, new features
                   | https://www.wolfssl.com/contact/
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html