Bugs item #1710834, was opened at 2007-05-01 17:43
Message generated for change (Comment added) made by jean-f-j
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1710834&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: compile or build problem
Group: portability problem
Status: Open
Resolution: None
Priority: 4
Private: No
Submitted By: Jean-F Jolin (jean-f-j)
Assigned to: Daniel Stenberg (bagder)
Summary: Cannot compile with Borland

Initial Comment:
Hi

I came to know that Borland can not compile the library libcurl.
This is reported on this link.
http://codepaks.sourceforge.net/broken-libs.htm

I found a way to make it compile correctly under libcurl version 7.16.2.
Chances are that this patch can be applied to archived version as well.

I published this patch on Borland's forums.
But people that didn't have a chance to read it won't benefit from it.

Article here.
http://newsgroups.borland.com/cgi-bin/dnewsweb?cmd=article&group=borland.public.cppbuilder.non-technical&item=108514&utag=

Where an interlocutor responsible of codepack
told me to send the patch, that it would be accepted.

The submitted patch here is different than the one supply on the forum.

Can you tell me if you have intention to apply it ?

Just to keep that newsgroup's community well informed.

Best regards,

Jean-François Jolin

----------------------------------------------------------------------

>Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-02 15:24

Message:
Logged In: YES
user_id=1246519
Originator: YES

Part 2 of 3
File Added: Part 2 of 3.zip

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-02 15:22

Message:
Logged In: YES
user_id=1246519
Originator: YES

diff seems really easy to get.
You shouldn't have any prob using it on your side.
Isn't it ?

See for yourself the result with winmerge.
Current uploaded zip contains screen shots.
Part 1 of 3
File Added: Part 1 of 3.zip

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-05-02 13:40

Message:
Logged In: YES
user_id=1110
Originator: NO

Really, all you need to do is to get diff and run 'diff -ur olddir newdir'
and send us the output.

diff -u is a generic output format for file changes and is widely accepted
and used all over the world in thousands of open source and other projects.
Perhaps even winmerge can output diffs in that format.

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-02 12:05

Message:
Logged In: YES
user_id=1246519
Originator: YES

Your are right. This is zip package. Unfortunately I'm not aware of
internal patch's submission of this group.

Just in case. Here is a little 2¢ (pennies) contribution. Winmerge (also
from sourceforge) is a wonderfull tool. That is what I use for file
comparison. It narrows down differences precisely.

To ease the pain all differences have been kept to a minimum in submitted
package. Very few lines in each files.

Their impact (lines with differences) can be read as follow. Total of 6
files.

Makefile.b32 (2 files) concern only borland build.
setup.h (2 files) contain preprocessor directives for borland
only.
config-win32.h Now contains preprocessor directives for borland only (in
newly uploaded file).
Makefile.inc May have an impact on other compilers. (Path contains '\'
on windows machine not '/'. A classic. )

Hope this help.
Wait for your repply.

Friendly.

JF

File Added: config-win32.h

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-05-02 04:21

Message:
Logged In: YES
user_id=1110
Originator: NO

That's not a patch, that's a zip package containing several complete files
and "applying" this change is painful and lots of work.

Please use diff -u to create a proper patch and submit that, or post it to
the curl-library mailing list.

I cannot comment on my intentions of applying the patch until I've read
and reviewed it.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1710834&group_id=976
Received on 2007-05-02