In before the buzzer :)

Two comments on the patch to reset.

1) do_curl_reset should call check_curl_state before calling curl_easy_reset

2) do_curl_reset should call do_curl_close instead of Py_DECREF(self)
when util_curl_init fails. When util_curl_init fails our object is left
in a invalid state, but we have no guarantee that Py_DECREF will
actually invoke the destructor. So I could still setopts and call
perform on my broken object. Where as if we close the object any later
calls will raise an exception.

Nathan Moore
_______________________________________________
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-and-python
Received on 2009-11-12