cURL Mailing List Monthly Index Single Mail
curl-library Mailing List Archives
Re: issue #33 in TODO-RELEASE
From: Daniel Stenberg <daniel-curl_at_haxx.se>
Date: Fri, 7 May 2004 09:30:17 +0200 (CEST)
On Thu, 6 May 2004, Seshubabu Pasam wrote:
> Here is the patch for issue #33. Here is what I did:
Thanks! Here follow a few comments I have on this patch:
> 1.) Added --enable-memcallback flag. This has no effect when --enable-debug
I think this code should be unconditionally used, but this approach certainly
> 2.) Added curl_set_mem_callbacks function in curl.h when CURL_MEMCALLBACK
The API needs to be present at all times. We don't want conditionally present
> 3.) Replaced malloc/free/realloc/strdup with
I think I would rather see that you keep the names malloc/free/realloc/strdup
We could instead just #define those names to use the proper global function
It would also make your patch MUCH simpler.
> 4.) url.c has 2 'free' calls that are not changed, since the memory is
Good, we must make sure that we maintain this ability.
> 5.) Replaced all calloc's with curl_malloc and memset.
I don't like that. We just recently introduced calloc() after years of not
> 9.) I am not sure if this is problematic: I removed "curl_free" function
It is problematic because curl_free() is useful and fills a purpose. It
The whole point of curl_free() is to allow applications to free memory
1. In Windows, you can link the lib and the app with two different memory
2. When we build libcurl with memory debugging enabled, we add data around
-- Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se Dedicated custom curl help for hire: http://haxx.se/curl.htmlReceived on 2004-05-07
These mail archives are generated by hypermail.
Page updated November 12, 2010.
web site info