cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Simple cookie interface!

From: Peteris Krumins [Newsgroups] <pknewsgroups_at_gmail.com>
Date: Fri, 29 Jul 2005 06:37:59 +0300

Daniel Stenberg wrote:

> On Thu, 28 Jul 2005, Peteris Krumins [Newsgroups] wrote:
>
>>> I have no easy work-around for this that doesn't involve simply
>>> strduping() the string on entry. But perhaps that's still better
>>> than requiring writable and disposable strings as input?
>>
>>
>> Agree. That is better. I attached a patch which changes this and
>> setopt(3) man page. Also numcookies was not set to 0 if cookies were
>> deleted.
>
>
> Thanks! I couldn't apply your patch since it didn't take my previous
> changes into account, but I applied the same logic manually.

Okay, next time I will send a diff from CVS.

I looked at CVS and you seems to have forgotten to remove a line from
curl/docs/libcurl/curl_easy_setopt.3 man page
"The passed string will get modified so make sure it's writable.".
Since it is no longer true, remove the line.

P.Krumins
Received on 2005-07-29