On Oct 27, 2006, at 3:18 AM, Daniel Stenberg wrote:

> On Thu, 26 Oct 2006, James Housley wrote:
>
>> My most recent patch.
>
> Thanks, but this version doesn't build on my box (Linux 2.6.17,
> glibc 2.3.6, gcc 4.1.2 20061020 (Debian 4.1.1-17)) box:
>
> gcc -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DCURLDEBUG -g -
> g -W -Wall -Wwrite-strings -pedantic -Wpointer-arith -Wnested-
> externs -Winline -Wmissing-prototypes -Wmissing-declarations -
> Wundef -Wno-long-long -Wsign-compare -Wfloat-equal -Wno-format-
> nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-
> statement -MT sftp.lo -MD -MP -MF .deps/sftp.Tpo -c sftp.c -o sftp.o

Right, I had them to make my work easier. I will remove them.

> sftp.c:167: warning: ignoring #pragma mark
> sftp.c:168: warning: ignoring #pragma mark LIBSSH2
> sftp.c:202: warning: ignoring #pragma mark
> sftp.c:203: warning: ignoring #pragma mark SCP
> sftp.c: In function 'Curl_scp_do':
> sftp.c:422: error: 'struct stat' has no member named 'st_atimespec'
> sftp.c:423: error: 'struct stat' has no member named 'st_mtimespec'

I will look at and fix this.

>
> The #pragmas shouldn't be present like that, and 'st_atimespec' and
> 'st_mtimespec' don't seem to be POSIX (http://www.opengroup.org/
> onlinepubs/007908799/xsh/sysstat.h.html).
>
> But other than so, I seem to be able to scp files just fine!
>
> If you clean this up and turn the fprintf() calls into infof()
> calls, I'll be read to commit it to allow more people to join in
> and help - only after I've released 7.16.0.

I notice there are fprintf(stderr in other places of the code. I
will convert mine.

Jim

--
/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
jeh@FreeBSD.org      http://www.FreeBSD.org     The Power to Serve
jim@TheHousleys.Net  http://www.TheHousleys.net
---------------------------------------------------------------------
"Eagles may soar, but weasels don't get sucked into jet engines"
     -- Anon