On Fri, 1 May 2009, Lénaïc Lefever wrote:

> In the Curl_done method in url.c (curl-7.19.4), the
> Curl_getoff_all_pipelines call happens before the conn->bits.done check.
>
> Wouldn't it be safer to check for conn->bits.done before calling
> Curl_getoff_all_pipelines to avoid possible SIGSEGVs?

Yes I think it would. Did you run the test suite fine with that change?

In general I don't like precautions like that in the code, but I figure fixing
the real flaw is a bit too much work for anyone at this point in time.

-- 
  / daniel.haxx.se