Guenter wrote:
> Hi Markus,
> although I did only take a quick look at the patch, I wonder that you
> change many types back to int - I did recently change these to avoid
> compiler warnings on 64bit systems. So I strongly recommend to stay with
> the types like size_t, ssize_t, curl_socklen_t and time_t as these are
> the types which are passed-in / returned from the C functions, and I
> assume (not tested your patch though) that changing back these types
> will again introduce the old + more new warnings.

I'm on 64bit, and changed the types to remove existing warnings.
I went to int instead of (s)size_t to avoid problems when passing a
reference to an integer, as int is 4bytes on 64bit, and size_t 8.

For curl_socklen_t, I failed, yes, but I'd prefer to commit what we have
now, and change it afterwards, as it will be easier.

MfG
Markus
Received on 2009-08-07