On Sun, Jan 3, 2010 at 2:05 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Sun, 3 Jan 2010, Claes Jakobsson wrote:
>
>> +  /* Remove the fragment part of the path. Per RFC 2396, this is always
>> the
>> +     last part of the URI. */
>> +  fragment = strrchr(path, '#');
>> +  if(fragment)
>> +    *fragment = 0;
>>
>> Altho the specification forbids any # in the fragment part I think it's
>> better to look for the leftmost # and consider everything after that the
>> fragment. That way "http://foo/#bar#baz" won't cause any problems.
>
> Yes, I agree. 'path' in this context is only the path fragment of the
> URI/URL anyway so doing a strchr() for '#' should be a better idea I think.
>

I also completely agree with the proposal. It would make us degrade
gracefully on such non valid URI.

An updated patch is attached. Do you think we should add a test for such URI?

Regards,
Julien

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html