cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] Curl_gethostname() may or may not return the hostname as a FQDN

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 26 Sep 2011 00:04:47 +0200 (CEST)

On Mon, 19 Sep 2011, Steve Holme wrote:

> * The first one adds support of HOSTNAME_MAX to smtp.c
> * The second moves HOSTNAME_MAX into curl_gethostname.h
> * The first tidies up the use of Curl_gethostname() into ntlm_msgs.c

Thanks, they've all been pushed now.

> I've also tried to comment the patch files / commit in the style that I've
> noticed you and Yang use with a brief description followed by a more
> informative description.

Great, that's exactly the style we use. Let me also just point out that for
the long description that follows the first short summary, we try to limit
line length to 72 columns. This limit makes operations such as "git log"
produce nicer-looking and easier-to-read outputs.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-09-26