cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Name lookup/DNS resolution mechanism of libcurl

From: Gisle Vanem <gvanem_at_broadpark.no>
Date: Wed, 10 Apr 2013 00:07:22 +0200

"Guenter" <lists_at_gknw.net> wrote:
> On 09.04.2013 20:01, Michael-O wrote:
> > Günter,
>>
>> were you able to look at the Makefiles of c-ares and curl?
>
> yes, today commited two patches - one for curl and one for c-ares ...

Thanks for fixing this. I wrote about this in this thread:
  http://curl.haxx.se/mail/lib-2013-01/0131.html

earlier this year. Your patch below looks good here.
Except:

+#if !defined(USE_ARES) && !defined(USE_THREADS_WIN32)
 # define USE_THREADS_WIN32 1
+#elif defined(USE_THREADS_WIN32) && USE_THREADS_WIN32 == 0
+# undef USE_THREADS_WIN32
 #endif

How can USE_THREADS_WIN32 both be defined and set to 0?
The "&& USE_THREADS_WIN32 == 0" part is superfluous AFAICS.

--gv

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-04-10