On 3 Apr 2006, at 17:05, Tor Arntsen wrote:
> Just one comment on the patch -
> the buffer definition seems to clearly define the flags field as a
> 4-byte
> integer, thus it shouldn't really be declared and described as
> 'long' in
> the code.

Ok, not a big problem.

> 'long' is 4 bytes on 32-bit systems and 8 bytes on 64-bit systems.
> 'int', on the other hand, is 4 bytes everywhere (using 'long' is
> common in
> the MS world but it's a very long time since 'int' used to be 16
> bits..)

Curious you're saying this because I'm a long-time unix and embedded
systems man; I suppose this last thing makes me subliminally think a
C int is 16 bits :)
Received on 2006-04-03