On Mon, 3 Apr 2006, Tor Arntsen wrote:

> Just one comment on the patch -

Yeps, and if 'long' is supposed to be used, you need to tell the printf() that
(%ld and %lx etc) as this is bound to cause compiler warnings otherwise.

A few more comments / questions:

1. What is the comment here meaning (from the patch)? What is the alternative
    mentioned?

+ lm_resp(lmbuffer, &ntlm->nonce[0], lmresp);
+ /* TODO alternative: lm_resp(ntbuffer, &ntlm->nonce[0], lmresp); */

2. it uses C99/c++ comments, while we aim for C89 compatibility (at least)

3. The failure return if gethostname() fails should probably also use failf()
    to set a human error string. But is that failure really that serious? The
    current code (before this patch) never sets a host name in the first place
    so perhaps just using a blank is an acceptable way if it fails to fetch it?
    (possibly with an infof() display)

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html