On Mon, 2004-03-22 at 08:21, Daniel Stenberg wrote:
> On Mon, 22 Mar 2004, hunter wrote:
>
> > All of the files in the zip required modification.
>
> Sorry, I didn't actually look at the files, I was more interested in your
> explanation why the changes are needed. I am under the impression that many
> people have built curl with MSVC using these files, so I'm surprised to see a
> need to modify a large number of files.
>

WEll it does not for me...

> > \lib\libcurl.def - export curlx_strtoll
>
> This is wrong. curlx_strtoll() is not exported, you should use the code from
> the lib: http://curl.haxx.se/mail/lib-2004-02/0215.html
>

I am not using this function, curl.exe fails to compile because of an
unresolved external reference - _curlx_strtoll
 
> > \lib\config-win32.h - commented 'if defined' does not work for socklen_t
>
> In what way doesn't it work? It was added there for a reason you know, and I
> think you need to clearly explain why this changes was required for you so
> that we can improve the check. David Byron has worked a lot on getting those
> things setup correctly.

I re-checked this, it works now - it did not in 7.10.0

>
> > \lib\setup.h - added defines for HAVE_ZLIB_H, etc.
>
> I'd say they belong in the Makefile or possibly in config-win32.h. Adding them
> unconditionally in setup.h seems wrong.

Ok, so they should be in the makefile - but they are not.

>
> > \scr\version - added CURL_VERSION_MAJOR, MINOR and PATCH
>
> I don't get it. What's wrong with the shipped version? And why do you define
> the same define (CURL_VERSION) 4 times?
>

I did not put CURL_VERSION in the version file four times - why don't
you look at the original source. I added CURL_VERSION_MAJOR, MINOR and
PATCH because they were not there. My guess is someone was duping the
CURL_VERSION's with the intent to change them to CURL_VERSION_MAJOR,
ETC and got distracted.
 
> > There were a lot of changes to the makefiles.
>
> What for?

No includes for zlib...

No content_encoding.obj for zlib...

Still using openssl 0.9.7a...

LINKLIB for instance was missing and the linker cannot resolve any
libraries.

/NODEFAULTLIBS:LIBC to silence link warning...

I will make a detailed description today and send it to you later. I
thought you would find it easy enough to compare the differences. Like I
tried to say in the begiining, I am not familiar with the code and my
solutions are probably not optimal - I offer them as a way to infer the
problem so that those who are familiar might make the best solutions.

I don't like having to modify the code in order to get it to compile.
And I do not believe that it compiles cleanly (with zlib include) for
anyone else, with VC6.

>
> --
> Daniel Stenberg -- http://curl.haxx.se/ -- http://daniel.haxx.se/
> [[ Do not send mails to this email address. They won't reach me. ]]

Chris.
Received on 2004-03-23