cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: Metalink support patch for curl

From: Tatsuhiro Tsujikawa <tatsuhiro.t_at_gmail.com>
Date: Thu, 28 Jun 2012 00:29:04 +0900

On Wed, Jun 27, 2012 at 8:26 PM, Yang Tse <yangsita_at_gmail.com> wrote:
> On Tue, Jun 26, 2012 at 4:00 PM, Tatsuhiro Tsujikawa
> <tatsuhiro.t_at_gmail.com> wrote:
>
>> Thank you for the suggestion. I updated Metalink message format
>> according to your suggestion.
>> Patch attached. If they are OK, tests need to be updated too.
>
> I updated it to show missing or invalid file name or resource as a
> warning, given that other files or resources might be processed. In
> that way 'parsing' final message should only be a 'failed' one in case
> to other file or resource is provided that allowed successful parsing.
>
> Updated existing test cases, and pushed five more metalink tests.
>

Thank you!

> From 2012 to 2017 all remain disabled yet.

The attached patch makes 2012 to 2016 pass.

The test 2017 treats log/.download2017 as invalid.
The directory traversals are explicitly prohibited by RFC 5854,
we did not make any remarks to file name starting '.'.
Should we drop those filenames?

Best regards,

Tatsuhiro Tsujikawa

>
> Thanks,
> --
> -=[Yang]=-
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-users
> FAQ:        http://curl.haxx.se/docs/faq.html
> Etiquette:  http://curl.haxx.se/mail/etiquette.html

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ: http://curl.haxx.se/docs/faq.html
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2012-06-27