Re: [PATCH] Active Mode FTPS Data Port Range
Date: Thu, 30 Apr 2009 11:31:07 +0200 (CEST)
On Sat, 25 Apr 2009, koettermarkus_at_gmx.de wrote:
> Accepted format for FTPPORT is
> ipv6:port(-range) as we never how to interpret it, you have to use
> for this case
> [ipv6] is accepted too.
> Patch is attached, tested with ipv4/6 for domains, addresses, interfaces.
Great! Thanks. A few nits on the patch:
o - ftp.c:924: warning: ISO C90 forbids mixed declarations and code
o - ftp.c:948:24: warning: C++ style comments are not allowed in ISO C90
(configure --enable-debug is your friend to catch these mistakes)
o - some lines are longer than 80 columns
o - there are some memory leaks situations added when ftp_state_use_port()
returns failure without free()ing the 'addr' memory.
o - any chance you can add some blurb to the docs for the option?
-- / daniel.haxx.seReceived on 2009-04-30