cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: debugging a crash in Curl_pgrsTime/checkPendPipeline?

From: <johansen_at_sun.com>
Date: Thu, 20 Aug 2009 16:17:05 -0700

On Fri, Aug 21, 2009 at 12:05:21AM +0200, Daniel Stenberg wrote:
> On Mon, 17 Aug 2009, johansen_at_sun.com wrote:
>
>> As promised, here's a new patch and webrev that encompasses the issues
>> I've run into with pipelining so far. This fixes the use after free
>> problems previously discovered, as well as the data corruption bug with
>> resumed transfers. I also found another case where the client might
>> reference a free'd easy_conn, and have fixed that as well.
>
>> If you have time to review this, I'd appreciate the feedback.
>
> No objections from me. I fixed some minor whitespace stuff (and one small
> "hunk" failed to apply against CVS for some reason) but no actual code
> changes. All test cases run fine.
>
> I'm prepared to commit this. You fine with that or is there more stuff in
> your pipe atm?

Yes, I'm fine with committing these changes. Thanks for
double-checking. We've gone almost a week on these patches with no
crashes. I'm comfortable with the changes at this point. If I should
see anything else go wrong, I'll be sure to follow up with the list.

Thanks for your help with this.

-j
Received on 2009-08-21