cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: obsolete infof() in nss.c

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Sun, 18 Oct 2009 19:31:41 +0200

Hi GŁn,

On Sunday 18 of October 2009 19:16:57 Guenter wrote:
> Hi,
> in line 1117 of current cvs nss.c we have:
> if(data->set.ssl.verifyhost == 1)
> infof(data, "warning: ignoring unsupported value (1) of
> ssl.verifyhost\n");
>
> but if you search for 'verifyhost' you find at line 638 that we have an
> if/else case for it which takes different actions depending on the
> 'verifyhost' setting - so I believe that this infof() is a leftover from
> former days, and can now be removed since not true anymore (also tested
> successfully that -k / --insecure works).
>
> comments?

I don't think so. The warning was added recently along with the code which
acts on the verifyhos value. The message is definitely *not* obsolete since
the value 1 is really not supported by lib/nss.c. The only supported values
are 0 and 2.

http://curl.haxx.se/libcurl/c/curl_easy_setopt.html#CURLOPTSSLVERIFYHOST
http://curl.haxx.se/mail/lib-2009-08/0106.html

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2009-10-18