cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] POP3: Expanded the supported commands

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 2 Apr 2012 23:55:20 +0200 (CEST)

On Mon, 2 Apr 2012, Steve Holme wrote:

> I have attached a patch that implements this and would appreciate it if
> someone could run it through the test harnesses just to make sure I didn't
> break anything ;-)

I just did! The test suite was happy but my compiler threw some warnings at me
that I fixed with this minor patch:

--- a/lib/pop3.c
+++ b/lib/pop3.c
@@ -452,7 +452,7 @@ static CURLcode pop3_command(struct connectdata *conn)
  {
    CURLcode result = CURLE_OK;
    struct pop3_conn *pop3c = &conn->proto.pop3c;
- char *command = NULL;
+ const char *command = NULL;

    /* Calculate the default command */
    if(pop3c->mailbox[0] == '\0' || conn->data->set.ftp_list_only) {
@@ -706,7 +706,6 @@ CURLcode pop3_perform(struct connectdata *conn,
  {
    /* this is POP3 and no proxy */
    CURLcode result = CURLE_OK;
- struct pop3_conn *pop3c = &conn->proto.pop3c;

    DEBUGF(infof(conn->data, "DO phase starts\n"));

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2012-04-02