cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: SSL/TLS support using Windows SSPI Schannel API

From: Marc Hoersken <info_at_marc-hoersken.de>
Date: Sun, 15 Apr 2012 09:10:03 +0200

Hello again,

I am still thinking about the version number being displayed. First of
all, I just pushed two changes to my repo:

commit af0ac5297ef1d9f44504b2e3613456cbb08ce5c8
Author: Marc Hoersken <info_at_marc-hoersken.de>
Date: Sun Apr 15 08:57:51 2012 +0200

    curl_sspi.c: Fallback to security function table version number

    Instead of reporting an unknown version, the interface version is used.

commit ef357c4fdf6fe899e373d8560061df9c621101b8
Author: Marc Hoersken <info_at_marc-hoersken.de>
Date: Sun Apr 15 08:53:11 2012 +0200

    curl_sspi.c: Fixed length of error code hex output

    The hex value was printed as signed 64-bit value on 64-bit systems:
    SEC_E_WRONG_PRINCIPAL (0xFFFFFFFF80090322)

    It is now correctly printed as the following:
    SEC_E_WRONG_PRINCIPAL (0x80090322)

You can find those changes in attached patch schannel_2012-04-15_1_diff.patch.

But the one thing I am still arguing about is the version prefix/identifier.
We now have SSPI/a.b.c.d for curl_sspi.c itself and
Schannel-SSPI/a.b.c.d for curl_schannel.c.

As "Schannel-SSPI" is somewhat redundant, I would prefer just "Schannel".
Attached you will find patch schannel_2012-04-15_2_diff.patch which
leaves it to the caller of Curl_sspi_version to insert additional
information into the version string before display. Therefore the
other SSPI implementations can choose which prefix they want to
display, e.g. NTLM/, etc.

I have not pushed this to my repo yet, because I would like to get
your feedback on this one.
So, please tell me, what do you think about the version prefix?

Best regards,
Marc

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2012-04-15