Hello,

I am glad the work to only use the multi-interface internally has finally
started.
IMHO the multi-interface is the better (but not so popular) interface
anyway.

One small nit-pick issue with the patch:

> int still_running;
>
> mcode = curl_multi_wait(multi, NULL, 0, 1000, NULL);
>
> if(mcode == CURLM_OK)
> mcode = curl_multi_perform(multi, &still_running);
>
> if(!still_running) {

When curl_multi_wait does not return CURLM_OK you access the uninitialized
variable 'still_running'. That's always bad...

Regards,

Christian

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-11-28