cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] cookie path match fail

From: YAMADA Yasuharu <yasuharu.yamada_at_access-company.com>
Date: Wed, 5 Jun 2013 12:03:56 +0900

2013/6/5 Daniel Stenberg <daniel_at_haxx.se>

> Is the modification of what is stored in the cookie file really necessary?
>
It will break compatibility with older libcurl versions. And vice versa,
> will it work properly to load cookie files written the old way?
>

It works properly to load cookie files written the old way.
I think backward compatibility is ok but forward compatibility is NG.
If you mind forward compatibility, I will create a patch which output
cookie file is almost the same style.
What should I do?

A more minor remark is that the check for URL fragments isn't necessary
> since they're stripped off from the URL earlier in the process.
>

I understand. I will create a patch.

Best regards,
thanks
===============
YAMADA Yasuharu
ACCESS CO., LTD.
Yasuharu.Yamada_at_access-company.com

2013/6/5 Daniel Stenberg <daniel_at_haxx.se>

> On Tue, 4 Jun 2013, YAMADA Yasuharu wrote:
>
> I apologize that cookie path match patch was incomplete. The patch does
>> not support the case that request url path is /hoge?fuga=xxx, this path
>> means /hoge/index.cgi?fuga=xxx. The patch could not match received path in
>> neither /hoge nor /hoge/.
>>
>> So, the policy of a new path are:
>> - struct Cookie keeps path without most-right '/' except root '/'.
>> - compare struct Cookie's path and request uri path without path
>> separator, query
>> separator or fragment separator.
>>
>
> Thanks! A question about a detail though:
>
> Is the modification of what is stored in the cookie file really necessary?
> It will break compatibility with older libcurl versions. And vice versa,
> will it work properly to load cookie files written the old way?
>
> A more minor remark is that the check for URL fragments isn't necessary
> since they're stripped off from the URL earlier in the process.
>
>
> --
>
> / daniel.haxx.se
> ------------------------------**------------------------------**-------
> List admin: http://cool.haxx.se/list/**listinfo/curl-library<http://cool.haxx.se/list/listinfo/curl-library>
> Etiquette: http://curl.haxx.se/mail/**etiquette.html<http://curl.haxx.se/mail/etiquette.html>
>

-- 
.
________________________________________
The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. 
This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. 
If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any.
Thank you for your cooperation.
________________________________________

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-06-05