cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH 1/7] Comment and debug output fixes.

From: Carlo Wood <carlo_at_alinoe.com>
Date: Sun, 9 Nov 2014 17:08:39 +0100

On Sat, 8 Nov 2014 18:29:33 -0500 (EST)
m brandenberg <mcbinc_at_panix.com> wrote:

> On Thu, 6 Nov 2014, Carlo Wood wrote:
>
> > diff --git a/lib/conncache.c b/lib/conncache.c
> > index 9522aeb..d07718e 100644
> > --- a/lib/conncache.c
> > +++ b/lib/conncache.c
> > @@ -152,6 +152,10 @@ CURLcode Curl_conncache_add_conn(struct
> > conncache
> *connc,
> > conn->connection_id = connc->next_connection_id++;
> > connc->num_connections++;
> >
> > + DEBUGF(infof(conn->data, "Added connection %d. "
> > + "The cache now contains %d members\n",
> > + conn->connection_id, connc->num_connections));
> > +
> > return CURLE_OK;
> > }
>
> 'connection_id' is a 'long', not an 'int', needs a
> '%ld' format specifier.

True, and num_connections is a size_t which is an unsigned long.
I copied the DEBUGF line where removal is printed - which uses
also %d for the num_connections. Maybe Daniel can fix this
when applying the patch, or do you want me to generate a new
diff (which isn't a natural way to use git-- and therefore not
very trivial :/).

-- 
Carlo Wood <carlo_at_alinoe.com>
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-09