cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: Two fixes

From: Patrick Monnerat <Patrick.Monnerat_at_datasphere.ch>
Date: Fri, 8 May 2015 16:25:54 +0200

 
Daniel Stenberg wrote:
>> I just fixed both problems I've reported recently:
> You rock Patrick, awesome!

Thank you but... well, this particular dangling pointer problem is
resolved, however I think there's potentially a risk of having more
troubles in the future:

If you reuse a connection, conn->dns_entry is null (so conn->ip_addr may
be dangling).
I've tried to nullify conn->ip_addr where conn->dns_entry in cleared,
but it reappears later as non-null in ftp_state_pasv_resp() while
conn->dns_entry is still NULL :-(
I suppose it is set from (dangling) tempaddr[i] or from the FTP data
channel connection... I do not really master this part of the library,
but I think there is some uncontrolled mess here.

Maybe a resolver+connect+happy_eyeball+proxy guru can audit this. He'll
probably be much more efficient than me.

Cheers,
Patrick

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-05-08