cURL / Mailing Lists / curl-library / Single Mail


RE: [PATCH v4] Add connection delay to Happy Eyeballs.

From: Steve Holme <>
Date: Tue, 5 Nov 2013 23:28:43 +0000

On Tue, 05 Nov 2013, Björn Stenberg wrote:

> > A couple of problems in the auto builds:
> >
> > * The Solaris 10 build is reporting "url.c, line 5581: warning:
> > end-of-loop code not reached" - while the loop breaks out because
> > of a break statement it would seem that this loop is no longer
> > required.
> You are right. The purpose of the loop was removed in the HE patch.
> I'm attaching a patch to remove it.

Thank you and pushed - commit comments updated to reference the original
commit ;-)

> > * The OpenSuSE 12.1 build is reporting valgrind memory issues in test
> > Whilst we typically see "in use at exit: 656 bytes in 4 blocks" is
> > there possibly something else connect wise that is making this test
> > fail? [2]
> This looks odd. I'll take a deeper look tomorrow.

Cheers again - I'm not too familiar with Valgrind and memcheck being a
Windows based developer (although I write lots of cross platform code), but
on the several occasions when I have broken the auto builds, some of them
have incorrectly given the same memory alert (with the same 656 bytes in 4
blocks) only for it to be something else in the test that I broke. You'll
certainly know more about this than me but my understanding is that Valgrind
usually lists the lines of code that don't free memory when it really is a
memory issue ;-)

Kind Regards


List admin:
Received on 2013-11-06