Re: [PATCH v4] Add connection delay to Happy Eyeballs.
Date: Tue, 5 Nov 2013 23:59:59 +0100
Steve Holme wrote:
> A couple of problems in the auto builds:
> * The Solaris 10 build is reporting "url.c, line 5581: warning: end-of-loop
> code not reached" - while the loop breaks out because of a break statement
> it would seem that this loop is no longer required.
You are right. The purpose of the loop was removed in the HE patch. I'm attaching a patch to remove it.
> * The OpenSuSE 12.1 build is reporting valgrind memory issues in test 583.
> Whilst we typically see "in use at exit: 656 bytes in 4 blocks" is there
> possibly something else connect wise that is making this test fail? 
This looks odd. I'll take a deeper look tomorrow.
-- BjörnReceived on 2013-11-06