cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH 2/2] ntlm_wb: Avoid invoking ntlm_auth helper with empty username

From: Michael Osipov <>
Date: Fri, 11 Jul 2014 15:45:39 +0200

Am 2014-07-11 13:35, schrieb David Woodhouse:
> On Fri, 2014-07-11 at 13:28 +0200, Michael Osipov wrote:
>> Am 2014-07-11 13:19, schrieb David Woodhouse:
>>> On Fri, 2014-07-11 at 13:04 +0200, Michael Osipov wrote:
>>>> Why do you provide a slash as a breaking char too? Backslash is the
>>>> only used char to separate domain from samaccountname.
>>> I didn't even look at that part — it's just in the context of my patch.
>>> I assume it's to allow people to specify the user on the command line
>>> with a slash instead of a backslash?
>> Backslash isn't a problem as long as you do:
>> $ curl --ntlm -u DOM\\michaelo http://...
> I agree. In similar code elsewhere I have not chosen to support the use
> of a forward slash; only the backslash.
> However, this is what curl already did before I looked at it. Removing
> it now would have the potential to break existing users.

I haven't seen any reference for that in the docs. This might be a safe
bet to remove an undocumented feature.

> Well, not that this code was working before I sent those two patches, so
> if you *really* want to make your case for removing the forward slash, I
> suppose that's fair enough. But you need to make it to someone other
> than me :)

If it was broken before, we aren't going to double-break stuff, are we?


List admin:
Received on 2014-07-11