curl / Mailing Lists / curl-library / Single Mail

curl-library

Re: Application gets blocked in libcurl v7.50.2

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 6 Mar 2017 22:48:46 +0100 (CET)

On Mon, 6 Mar 2017, Ray Satiro via curl-library wrote:

> Neither of those are returned though. For a different timeout case it
> appears CURLE_OK will be returned and nothing closed [1], and I can't see
> how CURLE_COULDNT_RESOLVE_HOST could be returned without checking
> Curl_resolver_is_resolved result.

Yes, that seems to be missing. I suppose it is a fairly rare condition and not
that many people use c-ares that explain why this hasn't been reported before.

> It's unclear to me whether ares_cancel needs to be called if
> Curl_resolver_is_resolved returns an error. Or maybe it depends on the
> error?

I belive it should be called for all errors. My variation of your patch looks
like this (also attached):
Received on 2017-03-06