Bugs item #1676581, was opened at 2007-03-08 15:06
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1676581&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: bad behaviour
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Justin Fletcher (gerph)
Assigned to: Nobody/Anonymous (nobody)
Summary: file handle leak in the main tool

Initial Comment:
Curl 7.16.1, src/main.c line 3909.

Currently:

if (!infd || stat(uploadfile, &fileinfo)) {
  helpf("Can't open '%s'!\n", uploadfile);
  return CURLE_READ_ERROR;
}

This should have the following inserted before the return in order to prevent a file handle leak :

  if (infd)
    fclose(infd);

In the case where the file has been opened, but cannot be stat'd, the file handle would have been leaked because the routine had returned without infd being closed, or infdfopen being set to TRUE.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1676581&group_id=976
Received on 2007-03-08