Bugs item #1710834, was opened at 2007-05-01 23:43
Message generated for change (Comment added) made by bagder
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1710834&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: compile or build problem
Group: portability problem
>Status: Closed
>Resolution: Invalid
Priority: 4
Private: No
Submitted By: Jean-F Jolin (jean-f-j)
Assigned to: Daniel Stenberg (bagder)
Summary: Cannot compile with Borland

Initial Comment:
Hi

I came to know that Borland can not compile the library libcurl.
This is reported on this link.
http://codepaks.sourceforge.net/broken-libs.htm

I found a way to make it compile correctly under libcurl version 7.16.2.
Chances are that this patch can be applied to archived version as well.

I published this patch on Borland's forums.
But people that didn't have a chance to read it won't benefit from it.

Article here.
http://newsgroups.borland.com/cgi-bin/dnewsweb?cmd=article&group=borland.public.cppbuilder.non-technical&item=108514&utag=

Where an interlocutor responsible of codepack
told me to send the patch, that it would be accepted.

The submitted patch here is different than the one supply on the forum.

Can you tell me if you have intention to apply it ?

Just to keep that newsgroup's community well informed.

Best regards,

Jean-François Jolin

----------------------------------------------------------------------

>Comment By: Daniel Stenberg (bagder)
Date: 2007-05-03 22:40

Message:
Logged In: YES
user_id=1110
Originator: NO

Personally I don't particularly care much about having it build for
borland, YOU do. But please drop your insults now and get back to the
technicalities.

1. I didn't ask why there were two header files. I asked why you needed
the #include files in them. No other system does, and those headers are
included by setup_once.h

2. CVS is for everyone who wants to build curl or libcurl with the latest
sources between the releases, like when you want to work on a bugfix or new
features. Even borland users could be in that situation. I don't want that
ability simply dismissed because it's not for the "typical users". To me,
it looks like you're removing a feature that previously existed. Heck, the
whole point of building libcurl is "internal" and not something "typical"
users do.

I find your attitude highly discouraging and I'm done spending/wasting
time on this. I'll close this now and wait for someone else that is truly
interested in getting the build system borland-friendly to show up.

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-03 17:05

Message:
Logged In: YES
user_id=1246519
Originator: YES

Let me explain this from another perspective. I'm a Borland's compiler
user. I didn't know nothing about libcurl before last week. I simply found
a way to make this tool works for Borland. That discovery can benefit to a
greater public and it is not an obligation for me. I can help you to reach
that newer public. If you are dedicted to your users, the rest is up to
you.

Answer #1 I don't know why _you_ use two differents setup.h file. Just
compare them and you'll see that they are different and needed in each
case.

Answer #2 Look in the makefile for microsoft VC they don't care nor they
don't need the CVS repository. Like the majority of us. The use of CVS is
probably internal to libcurl group (and should stay internal IMHO). So that
typical user who try to compile your library received at download time all
requested files and therefor dont depend on any CVS.

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-05-03 08:46

Message:
Logged In: YES
user_id=1110
Originator: NO

When _you_ want something, I think it is fair that _you_ spend that extra
time.

Now, regarding the patch I have two questions:

1 - Why are the two include files needed in src/setup.h and lib/setup.h ?

2 - You removed the makefile target for hugehelp.c. Did you really try
building from CVS with this makefile with that target removed? It seems to
be that it won't work...

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-03 02:08

Message:
Logged In: YES
user_id=1246519
Originator: YES

I know now, how long it take to procude it when the appropriate tool is
found.

I wouldn't have insisted like you did.
The reward simply doesn't worth it.
Because time lost and frustation came with it.
File Added: diff.txt

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-05-02 22:09

Message:
Logged In: YES
user_id=1110
Originator: NO

Are you serious?

I'm asking you to please provide your requested changes in diff -u
(unified) format. Several hundred previous contributors have managed to
provide changes in that format, why is that such a problem to you?

I rather have you spend another 30 minutes on making this a nice patch for
us to review and apply, than having me do it.

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-02 21:25

Message:
Logged In: YES
user_id=1246519
Originator: YES

Part 3 of 3
File Added: Part 3 of 3.zip

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-02 21:24

Message:
Logged In: YES
user_id=1246519
Originator: YES

Part 2 of 3
File Added: Part 2 of 3.zip

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-02 21:22

Message:
Logged In: YES
user_id=1246519
Originator: YES

diff seems really easy to get.
You shouldn't have any prob using it on your side.
Isn't it ?

See for yourself the result with winmerge.
Current uploaded zip contains screen shots.
Part 1 of 3
File Added: Part 1 of 3.zip

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-05-02 19:40

Message:
Logged In: YES
user_id=1110
Originator: NO

Really, all you need to do is to get diff and run 'diff -ur olddir newdir'
and send us the output.

diff -u is a generic output format for file changes and is widely accepted
and used all over the world in thousands of open source and other projects.
Perhaps even winmerge can output diffs in that format.

----------------------------------------------------------------------

Comment By: Jean-F Jolin (jean-f-j)
Date: 2007-05-02 18:05

Message:
Logged In: YES
user_id=1246519
Originator: YES

Your are right. This is zip package. Unfortunately I'm not aware of
internal patch's submission of this group.

Just in case. Here is a little 2¢ (pennies) contribution. Winmerge (also
from sourceforge) is a wonderfull tool. That is what I use for file
comparison. It narrows down differences precisely.

To ease the pain all differences have been kept to a minimum in submitted
package. Very few lines in each files.

Their impact (lines with differences) can be read as follow. Total of 6
files.

Makefile.b32 (2 files) concern only borland build.
setup.h (2 files) contain preprocessor directives for borland
only.
config-win32.h Now contains preprocessor directives for borland only (in
newly uploaded file).
Makefile.inc May have an impact on other compilers. (Path contains '\'
on windows machine not '/'. A classic. )

Hope this help.
Wait for your repply.

Friendly.

JF

File Added: config-win32.h

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-05-02 10:21

Message:
Logged In: YES
user_id=1110
Originator: NO

That's not a patch, that's a zip package containing several complete files
and "applying" this change is painful and lots of work.

Please use diff -u to create a proper patch and submit that, or post it to
the curl-library mailing list.

I cannot comment on my intentions of applying the patch until I've read
and reviewed it.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1710834&group_id=976
Received on 2007-05-03