Bugs item #3383692, was opened at 2011-08-01 15:09
Message generated for change (Comment added) made by bagder
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=3383692&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: RTSP
Group: bad behaviour
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: sco1 (sco1)
Assigned to: Daniel Stenberg (bagder)
Summary: GET PARAMETER request and body in response

Initial Comment:
When issuing a get parameter request if the response contains a body this last is skipped and the write call back is never called.
It seems that opt_no_body is not set to 'false' in rtsp_do function in rtsp.c file.
Curl / libcurl version is 7.21.7
I join a patch that seems to correct the behavior.

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2011-08-14 19:09

Message:
Thanks for the report, this problem is now fixed in the git repository.

To try it out, you either checkout/update your git clone:
http://curl.haxx.se/source.html

or you try tomorrow's daily snapshot: http://curl.haxx.se/snapshots/

----------------------------------------------------------------------

Comment By: sco1 (sco1)
Date: 2011-08-08 16:52

Message:
As I understand the code in function rtsp_do (file : rtsp.c) :
- the first part of code setup the rtsp request and also opt_no_body of
the related request. This option opt_no_body tells if the response of the
request will contain a body.
Some request never have body in response, some other always body in
response and some other can have it depending on the request parameters.
It's the case for GET_PARAMETER request, if there is parameters with the
request the body will be present in the response .

- the second part of code deal with rtsp header and try to know if the
request contains a body ... for the get_parameter request if there is a
body the opt_no_body is not changed , and if there is no body (in the
request) the opt_no_body is set to TRUE.

So the initial value of opt_no_body for GET_PARAMETER request shall be set
to FALSE and (for me) the comment above is still valid.
Am I right ? Maybe I missed something.
Let me know
Thanks.

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2011-08-07 22:22

Message:
Thanks.

But if GET unconditionally sets it to FALSE, then the comment above your
change is now wrong. It seems as if your bug report even says that it is
wrong already?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=3383692&group_id=976
Received on 2011-08-14